Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLL Davis wave speeds & Cartesian Flux Winters for polytropic Euler #1733

Merged
merged 14 commits into from
Nov 17, 2023
Merged

HLL Davis wave speeds & Cartesian Flux Winters for polytropic Euler #1733

merged 14 commits into from
Nov 17, 2023

Conversation

DanielDoehring
Copy link
Contributor

This prepares the deprecation of min_max_speed_naive in favor of min_max_speed_davis, see #1721 .

Convergence study of examples/tree_2d_dgsem/elixir_eulerpolytropic_convergence.jl

####################################################################################################
l2
rho                 rho_v1              rho_v2              
error     EOC       error     EOC       error     EOC       
1.67e-03  -         2.59e-03  -         3.28e-03  -         
1.32e-04  3.66      1.34e-04  4.27      2.06e-04  3.99      
1.02e-05  3.70      8.57e-06  3.97      1.24e-05  4.06      
6.56e-07  3.96      5.26e-07  4.03      7.26e-07  4.09      
3.58e-08  4.20      3.09e-08  4.09      4.52e-08  4.01      

mean      3.88      mean      4.09      mean      4.04      
----------------------------------------------------------------------------------------------------
linf
rho                 rho_v1              rho_v2              
error     EOC       error     EOC       error     EOC       
1.10e-02  -         1.33e-02  -         2.01e-02  -         
1.13e-03  3.28      9.13e-04  3.87      1.90e-03  3.40      
1.09e-04  3.38      8.65e-05  3.40      1.27e-04  3.90      
7.76e-06  3.82      5.84e-06  3.89      7.93e-06  4.00      
4.50e-07  4.11      3.45e-07  4.08      4.92e-07  4.01      

mean      3.64      mean      3.81      mean      3.83      
----------------------------------------------------------------------------------------------------

@github-actions GitHub Actions
Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@DanielDoehring DanielDoehring added enhancement New feature or request consistency Make Michael happy labels Nov 12, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 12, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8bdd0cd) 96.27% compared to head (42ef1c6) 96.28%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1733      +/-   ##
==========================================
+ Coverage   96.27%   96.28%   +0.01%     
==========================================
  Files         428      428              
  Lines       34563    34621      +58     
==========================================
+ Hits        33275    33333      +58     
  Misses       1288     1288
Flag Coverage Δ
unittests 96.28% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielDoehring DanielDoehring marked this pull request as ready for review November 12, 2023 16:29
@DanielDoehring DanielDoehring changed the title HLL Davis wave speeds & Cartesian FLux Winters for polytropic Euler HLL Davis wave speeds & Cartesian Flux Winters for polytropic Euler Nov 12, 2023
andrewwinters5000
andrewwinters5000 requested changes Nov 16, 2023
View reviewed changes
Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @DanielDoehring ! I just left a few comments.

examples/tree_2d_dgsem/elixir_eulerpolytropic_convergence.jl Show resolved Hide resolved
src/equations/polytropic_euler_2d.jl Show resolved Hide resolved
src/equations/polytropic_euler_2d.jl Outdated Show resolved Hide resolved
andrewwinters5000
andrewwinters5000 approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DanielDoehring DanielDoehring enabled auto-merge (squash) November 16, 2023 23:16
@DanielDoehring DanielDoehring merged commit c8e1f99 into trixi-framework:main Nov 17, 2023
34 checks passed
@DanielDoehring DanielDoehring deleted the HLL_Davis_Polytropic_Euler branch November 17, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewwinters5000 andrewwinters5000 andrewwinters5000 approved these changes

Assignees
No one assigned
Labels
consistency Make Michael happy enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielDoehring @andrewwinters5000